Add python3-colorama dependency - #892
Conversation
Signed-off-by: Peng Wang <penwang@qti.qualcomm.com>
There was a problem hiding this comment.
Hi! I don't think it is a good idea to add dependencies of actual ros packages here, and these should only be dependencies to support CI as a whole I believe.
Have you tried adding python3-colorama to rosdep?
(let me double check this internally as well, as I see in the console that rosdep is not even called indeed)
That's already done: https://github.com/ros/rosdistro/blob/2667056d0320bb77edf1e28fec13d56aa8d325e2/rosdep/python.yaml#L3476 But unfortunately, CI here does not use rosdep at all. I tried to introduce it a few years ago, but it would basically require completely rewriting how the CI scripts work. So I abandoned it then. I think this is the best we can do for now. Note that this will also require adding in |
|
ahh yes thanks @clalancette for clarifying. I looked at the base.yaml file, that's why I missed it. And indeed, pixi.toml addition needs to be done as well (colorama is on conda-forge). We should be able to use version 0.4.6 for this to match Ubuntu 26.04 |
|
@clalancette @knmcguire Thanks for your review and feedback, have added PR for Windows in pixi.toml: ros2/ros2#1857. Please help to review again. |
|
I had to make a port of your branch for here for me to test it out in CI. Linux: Windows CI run with pixi is running in the other PR |
3 participants
Description
Fix CI issue for ros2/ros2cli#1248. In that PR, we added color support for ros2cli,
python3-coloramais used for cross-platform colored terminal output.Did you use Generative AI?
No.
Additional Information
https://pypi.org/project/colorama/